Re: [discuss] Re: [PATCH][Fix][Resend] Fix Bug #4959: Page tables corrupted during resume on x86-64 (take 3)

["Siddha, Suresh B" <suresh.b.siddha@intel.com>]

On Sat, Oct 01, 2005 at 12:03:20PM +0200, Rafael J. Wysocki wrote:
> It shows that there's something wrong with get_smp_config(), but it shouldn't
> have been called in the first place, as it was a non-SMP kernel.
> 
> The appended patch fixes the issue for me, but still if I run an SMP kernel on this
> box, it crashes in get_smp_config().
> 
> If you want me to debug this further, please tell me what to do next.

Rafael, can you check if the appended patch fixes your issue.

thanks,
suresh


--- linux-2.6.14-rc2/arch/x86_64/kernel/mpparse.c~	2005-10-01 17:16:59.452285584 -0700
+++ linux-2.6.14-rc2/arch/x86_64/kernel/mpparse.c	2005-10-01 17:22:21.053394784 -0700
@@ -549,7 +549,7 @@
 		 * Read the physical hardware table.  Anything here will
 		 * override the defaults.
 		 */
-		if (!smp_read_mpc((void *)(unsigned long)mpf->mpf_physptr)) {
+		if (!smp_read_mpc(phys_to_virt(mpf->mpf_physptr))) {
 			smp_found_config = 0;
 			printk(KERN_ERR "BIOS bug, MP table errors detected!...\n");
 			printk(KERN_ERR "... disabling SMP support. (tell your hw vendor)\n");