From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] Re: [PATCH 2.6-mm 5/5] i2c: make i2c-isa drivers
Date: Sat, 01 Oct 2005 21:49:09 +0000 [thread overview]
Message-ID: <20051001214903.782cb7e3.khali@linux-fr.org> (raw)
In-Reply-To: <433D50FC.30907@free.fr>
Hi Laurent,
> In function i2c_isa_add_driver, copied driver should inherit the owner field
> as well as the name field.
>
>
> Signed-off-by: Laurent Riffard <laurent.riffard@free.fr>
> ---
>
> Index: linux-2.6-mm/drivers/i2c/busses/i2c-isa.c
> =================================> --- linux-2.6-mm.orig/drivers/i2c/busses/i2c-isa.c 2005-09-30 16:27:50.000000000 +0200
> +++ linux-2.6-mm/drivers/i2c/busses/i2c-isa.c 2005-09-30 16:34:00.903153000 +0200
> @@ -92,6 +92,7 @@
>
> /* Add the driver to the list of i2c drivers in the driver core */
> driver->driver.name = driver->name;
> + driver->driver.owner = driver->owner;
> driver->driver.bus = &i2c_bus_type;
> driver->driver.probe = i2c_isa_device_probe;
> driver->driver.remove = i2c_isa_device_remove;
>
>
This one doesn't apply, because of tabs/spaces conversions it seems.
Please resend in a suitable form.
BTW, I appreciate diffstat output in the patch headers, it helps
figuring out at a glance which files a patch affects and how.
Thanks,
--
Jean Delvare
next prev parent reply other threads:[~2005-10-01 21:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-09-30 16:52 [lm-sensors] [PATCH 2.6-mm 5/5] i2c: make i2c-isa drivers inherits Laurent Riffard
2005-10-01 21:49 ` Jean Delvare [this message]
2005-10-01 23:07 ` [lm-sensors] Re: [PATCH 2.6-mm 5/5] i2c: make i2c-isa drivers Laurent Riffard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051001214903.782cb7e3.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.