From: Ralf Baechle DL5RB <ralf@linux-mips.org>
To: Bob Brose N0QBJ <linuxhams@n0qbj-11.ampr.org>
Cc: linux-hams@vger.kernel.org
Subject: Re: [PATCH] ax25 fix char type assumption in ax25_digi structure
Date: Mon, 3 Oct 2005 14:58:00 +0100 [thread overview]
Message-ID: <20051003135800.GJ2624@linux-mips.org> (raw)
In-Reply-To: <20051003035120.21386.qmail@kunk.qbjnet.com>
On Mon, Oct 03, 2005 at 03:51:20AM -0000, Bob Brose N0QBJ wrote:
> This trivial fix allows ax25 IP to work on the PPC architecture.
> The patch is against 2.6.14-rc1 and works with a offset against
> 2.6.14-rc3 as well.
>
> If not explicitly declared, PPC assumes chars are unsigned.
> x86 assumes they are signed. The code in ax25_addr.c uses -1 with
> char lastrepeat in the ax25_digi struct which fails later comparisons
> to -1 on PPC. Explicitly declaring the char as signed char fixes the
> problem.
I'll take care of your patch.
Ralf
next prev parent reply other threads:[~2005-10-03 13:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-03 3:51 [PATCH] ax25 fix char type assumption in ax25_digi structure Bob Brose N0QBJ
2005-10-03 13:58 ` Ralf Baechle DL5RB [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-11-02 5:30 Bob Brose N0QBJ
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051003135800.GJ2624@linux-mips.org \
--to=ralf@linux-mips.org \
--cc=linux-hams@vger.kernel.org \
--cc=linuxhams@n0qbj-11.ampr.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.