From: "Jordan Crouse" <jordan.crouse@amd.com>
To: "Adrian Bunk" <bunk@stusta.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: AMD Geode GX/LX support
Date: Mon, 3 Oct 2005 13:46:55 -0600 [thread overview]
Message-ID: <20051003194655.GA30975@cosmic.amd.com> (raw)
In-Reply-To: <20051003180532.GE3652@stusta.de>
> > +config MGEODE_GX
> > + bool "Geode GX"
> > + help
> > + Select this for AMD Geode GX processors. Enables use of some extended
> > + instructions, and passes appropriate optimization flags to GCC.
> >...
>
> The "and passes appropriate optimization flags to GCC" part seems to be
> missing in your patches.
Yes - that is incorrect. As you can no doubt see, I cut-n-pasted from
another processor.
> And it's not clear to me how your new MGEODE_GX option relates to the
> already existing MGEODEGX1 option.
The already existing GEODEGX1 option as it stands has an invalid cache line
size, it should be 4 not 5. I'll fix that up with the next revision of the
patch.
Thanks for your comments,
Jordan
--
Jordan Crouse
Senior Linux Engineer
AMD - Personal Connectivity Solutions Group
<www.amd.com/embeddedprocessors>
next prev parent reply other threads:[~2005-10-03 19:29 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-03 17:47 [PATCH 1/7] AMD Geode GX/LX support Jordan Crouse
2005-10-03 18:05 ` Adrian Bunk
2005-10-03 19:46 ` Jordan Crouse [this message]
2005-10-05 19:26 ` Adrian Bunk
2005-10-03 18:08 ` [PATCH 1/7] " Zwane Mwaikambo
2005-10-03 19:01 ` Alan Cox
2005-10-03 19:55 ` Jordan Crouse
2005-10-03 20:46 ` Alan Cox
2005-10-03 22:22 ` Jordan Crouse
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051003194655.GA30975@cosmic.amd.com \
--to=jordan.crouse@amd.com \
--cc=bunk@stusta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.