Re: [uml-devel] Re: UML/2.6.14-rc3 doesn't work fixes

[Blaisorblade <blaisorblade@yahoo.it>]

On Tuesday 04 October 2005 01:38, Al Viro wrote:
> On Mon, Oct 03, 2005 at 08:30:23PM +0200, Blaisorblade wrote:
> > The second is that, even if x86_64 uses things such as  (from
> > arch/x86_64/mm/Makefile):
> >

> Err...  Kbuild won't know what to do with your subarch-y.  The way it works
> is simple - we are saying that e.g. bitops.o is a multi-part object with
> only one part, namely ../../i386/lib/bitops.o.  Said part is built by the
> normal Kbuild logics and then we get (dummy) linking, creating bitops.o.

I know about kbuild, I just forgot to mention adding:

obj-y += subarch.o

(which you add below).

I've been cleaning up the UML Makefiles for almost a year, when I was even 
more of a kernel newbie than I am now ;-)...

> > for most things (see arch/x86_64/oprofile/Makefile), and for highmem and
> > module I'd just do that by hand:
> >
> > highmem-y := $(SUBARCH_DIR)/mm/highmem.o
> > module-y := $(SUBARCH_DIR)/kernel/module.o
> >
> > with SUBARCH_DIR defined in arch/um/Makefile.

> Hrm...   That just might be usable, _if_ we never run into modular suckers;
> in that case we can do the following:

> ifneq ($(subarch-objs-y),)
> obj-y += subarch.o
> subarch-y = $(addprefix ../../$(SUBARCH),$(subarch-objs-y))
> endif

> in arch/um/scripts/Makefile.rules with
>
> subarch-y = .....
> subarch-$(CONFIG_MODULE) += kernel/module.o
> etc. in arch/um/sys-.../Makefile
Hmm, yes, nice.
> The thing is, if we _ever_ need a potentially modular object pulled from
> the underlying architecture that trick will break.
We would just do them by hand, in this case. And say "don't use subarch-objs-y 
for modular things".

In the existing case, I've pulled in the whole directory, since it had only 
one module (aes-586.o).

Ah, I must add aes-x86_64 too, now it exists.
> So far we do not and 
> since $(eval...) *is* a vile mess straight from the GNU intestine...
I do not fully agree about eval being evil, but I'm not gonna flame on this 
issue...
-- 
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade (Skype ID "PaoloGiarrusso", ICQ 215621894)
http://www.user-mode-linux.org/~blaisorblade

	

	
		
___________________________________ 
Yahoo! Mail: gratis 1GB per i messaggi e allegati da 10MB 
http://mail.yahoo.it



-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel