From: Andi Kleen <ak@suse.de>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org, fastboot@osdl.org
Subject: Re: [PATCH 1/2] x86_64 nmi_watchdog: Make check_nmi_watchdog static
Date: Tue, 4 Oct 2005 17:32:06 +0200 [thread overview]
Message-ID: <200510041732.07007.ak@suse.de> (raw)
In-Reply-To: <m1y859716y.fsf@ebiederm.dsl.xmission.com>
On Tuesday 04 October 2005 17:26, Eric W. Biederman wrote:
> Andi Kleen <ak@suse.de> writes:
> > On Tuesday 04 October 2005 17:11, Eric W. Biederman wrote:
> >> By using a late_initcall as i386 does we don't need to call
> >> check_nmi_watchdog manually after SMP startup, and we don't
> >> need different code paths for SMP and non SMP.
> >>
> >> This paves the way for moving apic initialization into init_IRQ,
> >> where it belongs.
> >
> > I don't like it. I want to see a clear message in the log when
> > the NMI watchdog doesn't work and with your patch that comes too late.
>
> Why is it to late?
It's after too much of the boot. e.g. consider analyzing log with a boot hang.
It's important to know if the NMI watchdog runs or not. For that it is
best when the test of it happens as early as possible.
>
> > -Andi (who has rejected similar patches before)
>
> Would it be more appropriate to make this a per cpu check?
That would be fine as long as it's as early as possible.
But I suspect you'll always need special cases for the BP
because it needs the timer running first.
-Andi
next prev parent reply other threads:[~2005-10-04 15:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-04 15:11 [PATCH 1/2] x86_64 nmi_watchdog: Make check_nmi_watchdog static Eric W. Biederman
2005-10-04 15:21 ` Andi Kleen
2005-10-04 15:26 ` Eric W. Biederman
2005-10-04 15:32 ` Andi Kleen [this message]
2005-10-04 16:01 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200510041732.07007.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=ebiederm@xmission.com \
--cc=fastboot@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.