All of lore.kernel.org
 help / color / mirror / Atom feed
From: "'Christoph Hellwig'" <hch@lst.de>
To: "Bagalkote, Sreenivas" <Sreenivas.Bagalkote@engenio.com>
Cc: 'Christoph Hellwig' <hch@lst.de>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] megaraid_sas: fix compat ioctl handling
Date: Wed, 5 Oct 2005 18:25:40 +0200	[thread overview]
Message-ID: <20051005162540.GA3930@lst.de> (raw)
In-Reply-To: <0E3FA95632D6D047BA649F95DAB60E57060CD21B@exa-atlanta>

> MEGASAS_IOC_FIRMWARE32 which is defined outside CONFIG_COMPAT is using
> struct compat_megasas_iocpacket which is inside the CONFIG_COMPAT. It
> still works because MEGASAS_IOC_FIRMWARE32 is not referenced elsewhere
> in the code. I wasn't sure if you inteneded this to be like this (to 
> force driver not to use FIRMWARE32 value in outside CONFIG_COMPAT).

as you said it shouldn't matter.  if you prefer it inside the ifdef
I can send an incremental patch to fix it up.

  reply	other threads:[~2005-10-05 16:25 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-04 22:48 [PATCH] megaraid_sas: fix compat ioctl handling Bagalkote, Sreenivas
2005-10-05 16:25 ` 'Christoph Hellwig' [this message]
  -- strict thread matches above, loose matches on Subject: below --
2005-10-06 14:03 Bagalkote, Sreenivas
2005-10-04 18:40 Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051005162540.GA3930@lst.de \
    --to=hch@lst.de \
    --cc=Sreenivas.Bagalkote@engenio.com \
    --cc=linux-scsi@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.