Re: [KJ] hexdigits definition consolidation [RESEND2]

[Masoud Sharbiani <masouds@masoud.ir>]

[-- Attachment #1: Type: text/plain, Size: 1097 bytes --]

On Thu, Oct 06, 2005 at 01:21:25AM +0400, Alexey Dobriyan wrote:
> On Wed, Oct 05, 2005 at 04:12:11PM -0400, Masoud Sharbiani wrote:
> > On Wed, Oct 05, 2005 at 11:25:33AM -0600, Matthew Wilcox wrote:
> > --- linux-2.6.clean/arch/cris/arch-v10/kernel/kgdb.c
> > +++ linux-2.6.patched/arch/cris/arch-v10/kernel/kgdb.c
> 
> Please, add "-p" to your diff(1) flags. It'd sometimes make reviewing
> much easier.
> 
> > @@ -557,8 +556,8 @@
> >  	char *sd;
> >  	int x = 0;
> >  	
> > -	for (s1 = (char*)s; (sd = gdb_cris_memchr(hexchars, *s1, base)) != NULL; ++s1)
> > -		x = x * base + (sd - hexchars);
> > +	for (s1 = (char*)s; (sd = gdb_cris_memchr(small_digits, *s1, base)) != NULL; ++s1)
> > +		x = x * base + (sd - small_digits);
> >          
> >          if (endptr)
> >          {
> 
> simple_strtol()

I think the reason that they have reimplemented these is that they want to have a separate function to avoid single stepping into the library functions and thus failing the kgdb. Same thing goes for reimplementations of strlen and other library functions in the same file.

cheers, 
Masoud 

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors