From: Martin Habets <errandir_news@mph.eclipse.co.uk>
To: alsa-devel@lists.sourceforge.net
Subject: Re: RFC - Clean up of ALSA kernel codes
Date: Fri, 7 Oct 2005 15:31:58 +0100 [thread overview]
Message-ID: <20051007143158.GA4598@palantir8> (raw)
In-Reply-To: <s5h8xx6bzgl.wl%tiwai@suse.de>
Takashi,
I applaud you for doing this. An additional item I can think of is
a call to authors to make sure the first printk argument is correct.
i.e.:
printk(KERN_INFO "lvi_frag...
in stead of
printk("lvi_frag...
On a related note: Is there a MAINTAINERS list for alsa drivers? Should
there be? Or should we use the one in the linux kernel?
Last but not least, I am personally confused when to use snd_printk,
snd_printd, snd_printdd or regular printk. On top of that there are
different debugging macros in different drivers. I'd appreciate any
guidelines you could give on this.
Martin
On Thu, Oct 06, 2005 at 02:29:46PM +0200, Takashi Iwai wrote:
> Hi,
>
> currently I'm working on clean up of ALSA kernel side codes.
> There have been complaints from kernel developers about the ALSA's
> own-styles, and I'm trying to reduce them.
-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl
next prev parent reply other threads:[~2005-10-07 14:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-06 12:29 RFC - Clean up of ALSA kernel codes Takashi Iwai
2005-10-07 14:31 ` Martin Habets [this message]
2005-10-07 14:50 ` Takashi Iwai
-- strict thread matches above, loose matches on Subject: below --
2005-10-06 20:51 Tom Watson
2005-10-07 7:16 ` Jaroslav Kysela
2005-10-07 10:05 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051007143158.GA4598@palantir8 \
--to=errandir_news@mph.eclipse.co.uk \
--cc=alsa-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.