From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Jiri Slaby <lnx4us@gmail.com>
Cc: David Vrabel <dvrabel@cantab.net>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>
Subject: Re: [patch] yenta: fix YENTA && !CARDBUS build
Date: Fri, 7 Oct 2005 20:07:11 +0100 [thread overview]
Message-ID: <20051007190710.GA22608@flint.arm.linux.org.uk> (raw)
In-Reply-To: <3888a5cd0510070934x39288f31m368c58e1dd59d699@mail.gmail.com>
On Fri, Oct 07, 2005 at 06:34:15PM +0200, Jiri Slaby wrote:
> On 10/7/05, David Vrabel <dvrabel@cantab.net> wrote:
> > (Previous patch left a warning.)
> >
> > yenta_socket no longer builds if CONFIG_CARDBUS is disabled. It doesn't
> > look like ene_tune_bridge is relevant in the !CARDBUS configuration so
> > I've just disabled it.
> >
> >
> > yenta: fix build if YENTA && !CARDBUS
> >
> > (struct pcmcia_socket).tune_bridge only exists if CONFIG_CARDBUS is set but
> > building yenta_socket without CardBus is valid.
> >
> This is a multi-part message in MIME format.
>
> Are you really sure, that you have read Documentation/SubmittingPatches and
> http://www.zip.com.au/~akpm/linux/patches/stuff/tpp.txt
> Nobody wants MIMEs. Include it as plain text
You're providing misleading advice. mimes are acceptable provided
each part is text/plain. And some folk need to attach rather than
inline patches to prevent white space damage from broken mailers.
And indeed David's were text/plain so there isn't a problem.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
prev parent reply other threads:[~2005-10-07 19:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-03 15:19 [patch] yenta: fix YENTA && !CARDBUS build David Vrabel
2005-10-07 13:43 ` David Vrabel
2005-10-07 16:34 ` Jiri Slaby
2005-10-07 19:07 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051007190710.GA22608@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=akpm@osdl.org \
--cc=dvrabel@cantab.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lnx4us@gmail.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.