From: Chris Wright <chrisw@osdl.org>
To: David Howells <dhowells@redhat.com>
Cc: torvalds@osdl.org, akpm@osdl.org, keyrings@linux-nfs.org,
linux-kernel@vger.kernel.org
Subject: Re: [Keyrings] [PATCH] Keys: Add LSM hooks for key management [try #2]
Date: Fri, 7 Oct 2005 15:04:26 -0700 [thread overview]
Message-ID: <20051007220426.GC5856@shell0.pdx.osdl.net> (raw)
In-Reply-To: <26883.1128700665@warthog.cambridge.redhat.com>
* David Howells (dhowells@redhat.com) wrote:
> +static inline int security_key_permission(key_ref_t key_ref,
> + struct task_struct *context,
> + key_perm_t perm)
> +{
> + return -1;
> +}
No solid reason on that one, might as well be 0 for consistency.
Other than that, looks good. It's going to conflict with some pending
changes I have, how shall we work that? I can put all of these in that
queue?
thanks,
-chris
next prev parent reply other threads:[~2005-10-07 22:04 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-07 14:07 [PATCH] Keys: Split key permissions checking into a .c file David Howells
2005-10-07 15:41 ` [PATCH] Keys: Possessor permissions should be additive David Howells
2005-10-07 15:57 ` [PATCH] Keys: Add LSM hooks for key management [try #2] David Howells
2005-10-07 16:08 ` [PATCH] Keys: Remove key duplication David Howells
2005-10-07 22:04 ` Chris Wright [this message]
2005-10-07 23:34 ` [Keyrings] [PATCH] Keys: Add LSM hooks for key management [try #2] David Howells
2005-10-07 23:35 ` Chris Wright
2005-10-07 23:38 ` David Howells
2005-10-07 23:45 ` David Howells
2005-10-07 23:46 ` Chris Wright
2005-10-07 23:46 ` Chris Wright
2005-10-08 6:51 ` [PATCH] Keys: Add LSM hooks for key management [try #3] Chris Wright
2005-11-01 14:16 ` [PATCH] Keys: Remove incorrect and obsolete '!' operators David Howells
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051007220426.GC5856@shell0.pdx.osdl.net \
--to=chrisw@osdl.org \
--cc=akpm@osdl.org \
--cc=dhowells@redhat.com \
--cc=keyrings@linux-nfs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.