From: khali@linux-fr.org (Jean Delvare)
To: lm-sensors@vger.kernel.org
Subject: [lm-sensors] Patch for i2c-elektor driver
Date: Fri, 07 Oct 2005 22:21:45 +0000 [thread overview]
Message-ID: <20051007222019.23b2c3ac.khali@linux-fr.org> (raw)
In-Reply-To: <eeae3ce2cd160ac835fcb05bb9a2d829@lizardlogic.co.uk>
Hi Stig,
> Thanks for the new patches. I tested them and they appear to work.
> However, the problem with dev_dbg message prefixes early in driver
> initialisation is still there:
>
> i2c-elektor: found cy82c693, config register 0x47 = 0xe1
> i2c-elektor: found API UP2000 like board, will probe PCF8584 later
> i2c-elektor: registers 0xe0000 remapped to fffffd00000e0000
> : Write fffffd00000e0001 0x80
> : Read fffffd00000e0001 0x00
> : Write fffffd00000e0000 0x55
> : Read fffffd00000e0000 0x55
> : Write fffffd00000e0001 0xA0
> : Read fffffd00000e0001 0x20
> : Write fffffd00000e0000 0x18
> : Read fffffd00000e0000 0xF8
> : Write fffffd00000e0001 0xC1
> : Read fffffd00000e0001 0x81
> i2c-algo-pcf.o: deteted and initialized PCF8584.
> i2c_adapter i2c-0: Registered as minor 0
> i2c_adapter i2c-0: registered as adapter #0
> i2c_adapter i2c-0: found device at 0xe0000
>
> We don't get the driver name until we call i2c_add_adapter in
> i2c-algo-pcf.c.
I get it now. I had missed the fact that pcf_isa_{set,get}byte would be
called during the initialization step.
> Should we revert the dev_dbg statements to pr_debugs for device byte
> read/writes? That doesn't sound very consistent though...
That's the only option as far as I can see. I'll do that.
Thanks,
--
Jean Delvare
prev parent reply other threads:[~2005-10-07 22:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-04 12:51 [lm-sensors] Patch for i2c-elektor driver Stig Telfer
2005-10-04 16:56 ` Jean Delvare
2005-10-04 21:23 ` Stig Telfer
2005-10-04 23:39 ` Jean Delvare
2005-10-04 23:46 ` Jean Delvare
2005-10-04 23:51 ` Greg KH
2005-10-06 12:46 ` Stig Telfer
2005-10-06 22:37 ` Jean Delvare
2005-10-07 15:30 ` Stig Telfer
2005-10-07 22:21 ` Jean Delvare [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051007222019.23b2c3ac.khali@linux-fr.org \
--to=khali@linux-fr.org \
--cc=lm-sensors@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.