All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] Unreachable Code
Date: Sat, 08 Oct 2005 18:42:55 +0000	[thread overview]
Message-ID: <20051008184255.GA12886@parisc-linux.org> (raw)
In-Reply-To: <20051006023754.35718.qmail@web34205.mail.mud.yahoo.com>

[-- Attachment #1: Type: text/plain, Size: 438 bytes --]

On Wed, Oct 05, 2005 at 07:37:54PM -0700, Aaron Grothe wrote:
> +++ linux-2.6.14-rc3-patch/net/rxrpc/transport.c	2005-10-06 04:45:59.000000000 +0200
> @@ -563,8 +563,6 @@ void rxrpc_trans_receive_packet(struct r
>  		kfree_skb(pkt);
>  	}
>  
> -	_leave("");
> -
>  } /* end rxrpc_trans_receive_packet() */

Why delete these?  They seem to be useful:

#define _leave(FMT, a...)       do { if (rxrpc_ktrace) kleave(FMT , ##a); } while(0)


[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2005-10-08 18:42 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-06  2:37 [KJ] Unreachable Code Aaron Grothe
2005-10-08 13:21 ` Alexey Dobriyan
2005-10-08 13:22 ` Alexey Dobriyan
2005-10-08 18:42 ` Matthew Wilcox [this message]
2005-10-08 20:23 ` Alexey Dobriyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051008184255.GA12886@parisc-linux.org \
    --to=matthew@wil.cx \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.