From mboxrd@z Thu Jan  1 00:00:00 1970
From: a.othieno@bluewin.ch (Arthur Othieno)
Date: Sat, 08 Oct 2005 22:16:33 +0000
Subject: Re: [KJ] [PATCH] Remove select_bits_alloc(), select_bits_free()
Message-Id: <20051008221633.GA10443@mars>
MIME-Version: 1
Content-Type: multipart/mixed; boundary="===============83419119638129269=="
List-Id: <kernel-janitors.vger.kernel.org>
References: <20051006152016.GA21578@mipter.zuzino.mipt.ru>
In-Reply-To: <20051006152016.GA21578@mipter.zuzino.mipt.ru>
To: kernel-janitors@vger.kernel.org

--===============83419119638129269==
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Sun, Oct 09, 2005 at 02:17:06AM +0400, Alexey Dobriyan wrote:
> On Fri, Oct 07, 2005 at 06:59:11PM -0400, Arthur Othieno wrote:
> > On Thu, Oct 06, 2005 at 07:20:16PM +0400, Alexey Dobriyan wrote:
> > > * Both are trivial wrappers.
> > > * Each wrapper is used only in one place.
> >
> > These managed to stay under you radar :)
> 
> Heh... Who greps for static functions? ;-)
> 
> > fs/compat.c:1597:static void *select_bits_alloc(int size)
> > fs/compat.c:1602:static void select_bits_free(void *bits, int size)
> > fs/compat.c:1666:	bits = select_bits_alloc(size);
> > fs/compat.c:1712:	select_bits_free(bits, size);
> 
> So, 2 ways: remove all, consolidate. Opinions?

As you noted earlier, these are pretty much redundant (across both
fs/{compat,select}.c). Removing all would be a better cleanup, no?

	Arthur

--===============83419119638129269==
Content-Type: text/plain; charset="iso-8859-1"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Disposition: inline

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

--===============83419119638129269==--