From: seb@frankengul.org
To: netfilter-devel@lists.netfilter.org
Subject: Re: num_possible_cpus() usage in iptables
Date: Mon, 10 Oct 2005 10:52:24 +0200 [thread overview]
Message-ID: <20051010085224.GC5157@frankengul.org> (raw)
In-Reply-To: <20051010081957.GA5091@rama.customers.eurospot.com>
On Mon, Oct 10, 2005 at 10:19:57AM +0200, Harald Welte wrote:
> On Sun, Oct 09, 2005 at 08:47:34PM -0700, David S. Miller wrote:
> >
> > Guys, you can't use this interface like that.
> >
> > It's a _COUNT_ of the number of possible processors, not the number of
> > the higest PHYSICAL cpu index.
>
> thanks, Dave. It's very surprising that nobody apparently hit this
> before.
>
Well, I did and it's not so surprising.
2 way Sparc used as firewall are quite uncommon.
Moreover, the bug will bite only on special models that have this numbering.
There shouldn't be too much people in this case.
Please consider me as a worst case scenario :).
(SMP + sparc64 + firewall + cpu 0 and 2).
> I'll cook up a patch later today.
>
> > will return 2. This is not just theoretical, Ultra60 sparc64 systems
> > have this exact physical cpu numbering.
>
> I see :(
prev parent reply other threads:[~2005-10-10 8:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-10 3:47 num_possible_cpus() usage in iptables David S. Miller
2005-10-10 6:23 ` Eric Dumazet
2005-10-11 0:27 ` David S. Miller
2005-10-11 14:35 ` Harald Welte
2005-10-11 20:00 ` David S. Miller
2005-10-10 8:19 ` Harald Welte
2005-10-10 8:52 ` seb [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051010085224.GC5157@frankengul.org \
--to=seb@frankengul.org \
--cc=netfilter-devel@lists.netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.