From: Chris Wright <chrisw@osdl.org>
To: Grzegorz Nosek <grzegorz.nosek@gmail.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: sys_sendfile oops in 2.6.13?
Date: Wed, 12 Oct 2005 10:38:30 -0700 [thread overview]
Message-ID: <20051012173830.GP7991@shell0.pdx.osdl.net> (raw)
In-Reply-To: <121a28810510110156q1369b9dg@mail.gmail.com>
* Grzegorz Nosek (grzegorz.nosek@gmail.com) wrote:
> --- linux-2.6/fs/read_write.c~ 2005-10-06 21:35:03.000000000 +0200
> +++ linux-2.6/fs/read_write.c 2005-10-05 19:14:04.000000000 +0200
> @@ -719,7 +719,7 @@
> current->syscr++;
> current->syscw++;
>
> - if (*ppos > max)
> + if (ppos && *ppos > max)
> retval = -EOVERFLOW;
This doesn't make sense. ppos must not be NULL.
Code looks like this:
if (!ppos)
ppos = &in_file->f_pos;
...
pos = *ppos;
...
if (*ppos > max)
So it can't be NULL, and if somehow it were, the oops would've already
happened.
next prev parent reply other threads:[~2005-10-12 17:38 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-11 8:56 sys_sendfile oops in 2.6.13? Grzegorz Nosek
2005-10-11 14:53 ` Jiri Slaby
2005-10-12 4:00 ` Andy Isaacson
2005-10-12 9:11 ` Grzegorz Nosek
2005-10-12 17:38 ` Chris Wright [this message]
2005-10-12 20:06 ` Grzegorz Nosek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051012173830.GP7991@shell0.pdx.osdl.net \
--to=chrisw@osdl.org \
--cc=grzegorz.nosek@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.