All of lore.kernel.org
 help / color / mirror / Atom feed
From: Deepak Saxena <dsaxena@plexity.net>
To: linux-mtd@lists.infradead.org
Subject: [PATCH] [Trivial] Make physmap messages more user friendly
Date: Thu, 13 Oct 2005 18:07:26 -0700	[thread overview]
Message-ID: <20051014010726.GA28898@plexity.net> (raw)


Can I commit the following to CVS? It makes the message a bit more
readalbe (and obvious that it is in hex) and tells the user if 
the probe failed.

Signed-off-by: Deepak Saxena <dsaxena@plexity.net>

diff --git a/drivers/mtd/maps/physmap.c b/drivers/mtd/maps/physmap.c
--- a/drivers/mtd/maps/physmap.c
+++ b/drivers/mtd/maps/physmap.c
@@ -50,11 +50,12 @@ static int __init init_physmap(void)
 	static const char *rom_probe_types[] = { "cfi_probe", "jedec_probe", "map_rom", NULL };
 	const char **type;
 
-       	printk(KERN_NOTICE "physmap flash device: %lx at %lx\n", physmap_map.size, physmap_map.phys);
+       	printk(KERN_NOTICE "MTD physmap flash device: %#010lx @ %#010lx\n", 
+			physmap_map.size, physmap_map.phys);
 	physmap_map.virt = ioremap(physmap_map.phys, physmap_map.size);
 
 	if (!physmap_map.virt) {
-		printk("Failed to ioremap\n");
+		printk("MTD physmap: Failed to ioremap\n");
 		return -EIO;
 	}
 
@@ -90,6 +91,8 @@ static int __init init_physmap(void)
 		add_mtd_device(mymtd);
 
 		return 0;
+	} else {
+		printk("MTD physmap: failed to probe flash\n");
 	}
 
 	iounmap(physmap_map.virt);

-- 
Deepak Saxena - dsaxena@plexity.net - http://www.plexity.net

Even a stopped clock gives the right time twice a day.

             reply	other threads:[~2005-10-14 17:25 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-14  1:07 Deepak Saxena [this message]
2005-10-18 23:34 ` [PATCH] [Trivial] Make physmap messages more user friendly Jörn Engel
2005-10-19  6:37   ` Thomas Gleixner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051014010726.GA28898@plexity.net \
    --to=dsaxena@plexity.net \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.