All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] Get rid of yield()
Date: Fri, 14 Oct 2005 11:46:19 +0000	[thread overview]
Message-ID: <20051014114619.GA16113@parisc-linux.org> (raw)
In-Reply-To: <20051013191321.GA22138@masoud.ir>

[-- Attachment #1: Type: text/plain, Size: 778 bytes --]

On Thu, Oct 13, 2005 at 03:13:21PM -0400, Masoud Sharbiani wrote:
> Hello, 
> the following patch removes yield() from all drivers. They have been replaced by schedule_timeout() or cond_resched(). Please verify and comment.

You didn't even compile-test these, did you?

> diff --git a/drivers/net/depca.c b/drivers/net/depca.c
> --- a/drivers/net/depca.c
> +++ b/drivers/net/depca.c
> @@ -762,9 +762,7 @@ static int __init depca_hw_init (struct 
>  		/* Trigger an initialization just for the interrupt. */
>  		outw(INEA | INIT, DEPCA_DATA);
>  
> -		delay = jiffies + HZ/50;
> -		while (time_before(jiffies, delay))
> -			yield();
> +		schedule_timeout(HZ/50);
>  
>  		irqnum = probe_irq_off(irq_mask);
>  

This one adds a warning -- the delay variable is no longer used.


[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2005-10-14 11:46 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-13 19:13 [KJ] [PATCH] Get rid of yield() Masoud Sharbiani
2005-10-13 23:30 ` Nish Aravamudan
2005-10-14 11:46 ` Matthew Wilcox [this message]
2005-10-14 13:35 ` Nish Aravamudan
2005-10-14 14:06 ` Matthew Wilcox
2005-10-14 14:16 ` Masoud Sharbiani
2005-10-14 14:17 ` Nish Aravamudan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051014114619.GA16113@parisc-linux.org \
    --to=matthew@wil.cx \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.