All of lore.kernel.org
 help / color / mirror / Atom feed
From: Matthew Wilcox <matthew@wil.cx>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] Get rid of yield()
Date: Fri, 14 Oct 2005 14:06:49 +0000	[thread overview]
Message-ID: <20051014140649.GE16113@parisc-linux.org> (raw)
In-Reply-To: <20051013191321.GA22138@masoud.ir>

[-- Attachment #1: Type: text/plain, Size: 610 bytes --]

On Fri, Oct 14, 2005 at 06:35:16AM -0700, Nish Aravamudan wrote:
> And from a functional perspective, this is clearly a case where there
> is only one state that will match how the old code worked --
> TASK_UNINTERRUPTIBLE. If one were to use TASK_INTERRUPTIBLE, there is
> no guarantee that a single schedule_timeout(HZ/50) call would last the
> full request time, so you'd need to loop there as well.

Do you think it's worth putting a WARN_ON(current->state == TASK_RUNNING)
into schedule_timeout(), or are there legitimate reasons for occasionally
calling schedule_timeout() with the task in TASK_RUNNING?

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

  parent reply	other threads:[~2005-10-14 14:06 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-13 19:13 [KJ] [PATCH] Get rid of yield() Masoud Sharbiani
2005-10-13 23:30 ` Nish Aravamudan
2005-10-14 11:46 ` Matthew Wilcox
2005-10-14 13:35 ` Nish Aravamudan
2005-10-14 14:06 ` Matthew Wilcox [this message]
2005-10-14 14:16 ` Masoud Sharbiani
2005-10-14 14:17 ` Nish Aravamudan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051014140649.GE16113@parisc-linux.org \
    --to=matthew@wil.cx \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.