Re: [PATCH] fbdev: fix the fb_find_nearest_mode() function

[Michal Januszewski <spock@gentoo.org>]

[-- Attachment #1: Type: text/plain, Size: 1281 bytes --]

On Fri, Oct 14, 2005 at 08:18:08AM +0800, Antonino A. Daplas wrote:

> > In case you're wondering why would anyone ever need to have
> > var->pixclock set to 0 -- I was using it to denote modes with a default
> > refresh rate set by the hardware (well, the Video BIOS to be more
> > specific). Please let me know is this is very wrong, but I just didn't
> > see any other way of doing it.
> 
> No, it's not wrong. But it is preferrable to have a nonzero value in
> var->pixclock (whether calculated or via a VBE function call).
> 
> Still, I agree with you to initialize mode->refresh to zero (or perhaps
> -1 to to denote a divide by zero) for these cases.

OK, nice. I'd say that 0 might be a little cleaner (we're avoiding
<nn>x<nn>-4294967295 entries in the sysfs nodes without having to
write any additional code). Also, no one should be dividing anything by
mode->refresh without checking its contents first, so having a zero
there doesn't seem like something dangerous. But, ultimately it's
up to you to decide, of course.

-- 
Michal Januszewski                                Gentoo Linux Developer
cell: +48504917690                         http://dev.gentoo.org/~spock/
JID: spock@im.gentoo.org               freenode: #gentoo-dev, #gentoo-pl


[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]