All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Christian Krause <chkr@plauener.de>
Cc: linux-kernel@vger.kernel.org, stable@kernel.org,
	Chris Wright <chrisw@osdl.org>,
	Parag Warudkar <kernel-stuff@comcast.net>
Subject: Re: [PATCH] Re: bug in handling of highspeed usb HID devices
Date: Fri, 14 Oct 2005 16:42:25 -0700	[thread overview]
Message-ID: <20051014234225.GA11301@kroah.com> (raw)
In-Reply-To: <m3oe5riwib.fsf@gondor.middle-earth.priv>

On Fri, Oct 14, 2005 at 07:57:45PM +0200, Christian Krause wrote:
> --- linux-2.6.13.4/drivers/usb/input/hid-core.c.old	2005-10-12 21:29:29.000000000 +0200
> +++ linux-2.6.13.4/drivers/usb/input/hid-core.c	2005-10-12 21:31:02.000000000 +0200
> @@ -1667,11 +1667,6 @@ static struct hid_device *usb_hid_config
>  		if ((endpoint->bmAttributes & 3) != 3)		/* Not an interrupt endpoint */
>  			continue;
>  
> -		/* handle potential highspeed HID correctly */
> -		interval = endpoint->bInterval;
> -		if (dev->speed == USB_SPEED_HIGH)
> -			interval = 1 << (interval - 1);
> -

Did you try this patch out?  It is wrong.  Please look at the compiler
warning that this change generates and redo the patch.

thanks,

greg k-h

  reply	other threads:[~2005-10-14 23:42 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-12 19:55 bug in handling of highspeed usb HID devices Christian Krause
2005-10-13 22:48 ` Greg KH
2005-10-14 17:57   ` [PATCH] " Christian Krause
2005-10-14 18:09     ` Greg KH
2005-10-14 17:57   ` Christian Krause
2005-10-14 23:42     ` Greg KH [this message]
2005-10-15  1:43       ` Parag Warudkar
2005-10-15  2:18         ` Greg KH
2005-10-15  8:24           ` Christian Krause
  -- strict thread matches above, loose matches on Subject: below --
2005-10-13 19:53 kernel-stuff
2005-10-13 21:25 ` Chris Wright

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051014234225.GA11301@kroah.com \
    --to=greg@kroah.com \
    --cc=chkr@plauener.de \
    --cc=chrisw@osdl.org \
    --cc=kernel-stuff@comcast.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=stable@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.