From: Jens Axboe <axboe@suse.de>
To: Grzegorz Kulewski <kangur@polcom.net>
Cc: li nux <lnxluv@yahoo.com>, Erik Mouw <erik@harddisk-recovery.com>,
colin <colin@realtek.com.tw>,
linux-kernel@vger.kernel.org
Subject: Re: A problem about DIRECT IO on ext3
Date: Mon, 17 Oct 2005 11:17:10 +0200 [thread overview]
Message-ID: <20051017091710.GT2811@suse.de> (raw)
In-Reply-To: <Pine.LNX.4.63.0510171109250.21130@alpha.polcom.net>
On Mon, Oct 17 2005, Grzegorz Kulewski wrote:
> On Mon, 17 Oct 2005, Jens Axboe wrote:
> >>how to correct this problem ?
> >
> >See your buffer address, it's not aligned. You need to align that as
> >well. This is needed because the hardware will dma directly to the user
> >buffer, and to be on the safe side we require the same alignment as the
> >block layer will normally generate for file system io.
> >
> >So in short, just align your read buffer to the same as your block size
> >and you will be fine. Example:
> >
> >#define BS (4096)
> >#define MASK (BS - 1)
> >#define ALIGN(buf) (((unsigned long) (buf) + MASK) & ~(MASK))
> >
> >char *ptr = malloc(BS + MASK);
> >char *buf = (char *) ALIGN(ptr);
> >
> >read(fd, buf, BS);
>
> Shouldn't one use posix_memalign(3) for that?
Dunno if one 'should', one 'can' if one wants to. I prefer to do it
manually so I don't have to jump through #define hoops to get at it
(which, btw, still doesn't expose it on this machine).
--
Jens Axboe
next prev parent reply other threads:[~2005-10-17 9:16 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-08-29 12:15 A problem about DIRECT IO on ext3 colin
2005-08-29 13:29 ` Erik Mouw
2005-08-31 8:07 ` Jens Axboe
2005-08-31 11:12 ` Erik Mouw
2005-08-31 11:15 ` Jens Axboe
2005-10-17 8:52 ` li nux
2005-10-17 8:58 ` li nux
2005-10-17 9:03 ` Jens Axboe
2005-10-17 9:15 ` Grzegorz Kulewski
2005-10-17 9:17 ` Jens Axboe [this message]
2005-10-17 9:41 ` li nux
2005-10-17 9:51 ` Jens Axboe
2005-10-17 16:36 ` Badari Pulavarty
2005-10-17 17:53 ` Jens Axboe
-- strict thread matches above, loose matches on Subject: below --
2005-08-29 13:21 colin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051017091710.GT2811@suse.de \
--to=axboe@suse.de \
--cc=colin@realtek.com.tw \
--cc=erik@harddisk-recovery.com \
--cc=kangur@polcom.net \
--cc=linux-kernel@vger.kernel.org \
--cc=lnxluv@yahoo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.