From: Christoph Hellwig <hch@infradead.org>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: linux-scsi@vger.kernel.org, Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] dec_esp: Use physical addresses
Date: Mon, 17 Oct 2005 11:42:07 +0100 [thread overview]
Message-ID: <20051017104207.GA22710@infradead.org> (raw)
In-Reply-To: <20051015012630.GA20981@linux-mips.org>
On Sat, Oct 15, 2005 at 02:26:31AM +0100, Ralf Baechle wrote:
> FYI. This is part of a larger MIPS patch which I'd like to submit
> to akpm as a single patch.
Please don't do that _ever_. (dito for the other bits sent out)
scsi patches should be submitted to linux-scsi as individual patcvhes.
> Use physical addresses at the interface level, letting drivers remap
> them as appropriate.
> - esp->eregs = (struct ESP_regs *) (system_base + IOASIC_SCSI);
> + esp->eregs = (void *)CKSEG1ADDR(dec_kn_slot_base +
> + IOASIC_SCSI);
Both the old and new code look very odd. This looks like iomaped-ish
memory and should be using some iomap variant. The patch is probably
okay for now, but I'd prefer if this used the proper APIs.
next prev parent reply other threads:[~2005-10-17 10:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-15 1:26 [PATCH] dec_esp: Use physical addresses Ralf Baechle
2005-10-17 10:42 ` Christoph Hellwig [this message]
2005-10-25 15:13 ` Maciej W. Rozycki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051017104207.GA22710@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=linux-scsi@vger.kernel.org \
--cc=ralf@linux-mips.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.