From: Andi Kleen <ak@suse.de>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Tim Schmielau <tim@physik3.uni-rostock.de>,
nyk <nyk@giantx.co.uk>, lkml <linux-kernel@vger.kernel.org>
Subject: Re: [patch] Re: 2.6.14-rc4-mm1 ntfs/namei.c missing compat.h?
Date: Mon, 17 Oct 2005 20:02:23 +0200 [thread overview]
Message-ID: <200510172002.24210.ak@suse.de> (raw)
In-Reply-To: <1129572062.2424.3.camel@localhost>
On Monday 17 October 2005 20:01, Alan Cox wrote:
> On Llu, 2005-10-17 at 18:41 +0200, Andi Kleen wrote:
> > IMHO the right fix is to put that atomic scrub thingy into another
> > include file. It seems to cause major additional include dependencies and
> > is only used in a single file right now.
>
> Every file I looked at (I've not looked at NTFS) included types.h if it
> included atomic.h but sometimes directly or indirectly after atomic.h
> rather than before.
>
> I was thinking of just writing a tool to find the other cases and then
> fix those I can.
I think it is far better you do it in a different macro in a different file
without any nasty dependencies. What you're trying to do has nothing
to do with atomic_t anyways. It is just abuse of atomic.h
-Andi
next prev parent reply other threads:[~2005-10-17 18:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-17 14:49 2.6.14-rc4-mm1 ntfs/namei.c missing compat.h? nyk
2005-10-17 15:09 ` Anton Altaparmakov
2005-10-17 16:33 ` [patch] " Tim Schmielau
2005-10-17 16:41 ` Andi Kleen
2005-10-17 18:01 ` Alan Cox
2005-10-17 18:02 ` Andi Kleen [this message]
2005-10-17 19:39 ` nyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200510172002.24210.ak@suse.de \
--to=ak@suse.de \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=nyk@giantx.co.uk \
--cc=tim@physik3.uni-rostock.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.