From: Stephen Hemminger <shemminger@osdl.org>
To: Jonathan Chambers` <chamber_j@hotmail.com>
Cc: bridge@lists.osdl.org
Subject: Re: [Bridge] Bridge Control using sysfs and Spinlocks
Date: Tue, 18 Oct 2005 09:42:53 -0700 [thread overview]
Message-ID: <20051018094253.50003d33@localhost.localdomain> (raw)
In-Reply-To: <BAY107-F513CA16D038A97C9816C388710@phx.gbl>
On Tue, 18 Oct 2005 13:23:46 +0100
"Jonathan Chambers`" <chamber_j@hotmail.com> wrote:
> I am attempting to change the bridge kernel module so that I have complete
> control over the port states from user space via sysfs.
>
> On code inspection I can see that whenever a reconfiguration of the bridge
> itself is made, i.e. ageing time, forward delay, hello time, etc. then there
> is a spin_lock_bh before the reconfiguration and a spin_unlock_bh after
> reconfiguration.
Yes, makes sense to lock those operations. Looks like a simple oversight.
> However, when a reconfiguration of a bridge PORT is made e.g. path cost,
> priority then the spin lock mechanism is not used. Is this correct
> operation? (The old ioctl method uses spin locks on bridge port
> reconfiguration, whereas I am reconfiguring via sysfs)
>
> If I am to change the bridge module to accept requests to change the port
> state should I be using the spin locks?
>
> Thanks in advance
>
> Jon Chambers.
>
> _________________________________________________________________
> MSN Messenger 7.5 is now out. Download it for FREE here.
> http://messenger.msn.co.uk
>
--
Stephen Hemminger <shemminger@osdl.org>
OSDL http://developer.osdl.org/~shemminger
prev parent reply other threads:[~2005-10-18 16:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-18 12:23 [Bridge] Bridge Control using sysfs and Spinlocks Jonathan Chambers`
2005-10-18 16:42 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051018094253.50003d33@localhost.localdomain \
--to=shemminger@osdl.org \
--cc=bridge@lists.osdl.org \
--cc=chamber_j@hotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.