Re: [PATCH] - create common header for init/main.c called init functions

[Adrian Bunk <bunk@stusta.de>]

On Tue, Oct 18, 2005 at 07:11:09PM -0400, Arthur Othieno wrote:
> On Fri, Oct 14, 2005 at 01:42:10AM +0100, Ben Dooks wrote:
> > init/main.c calls a number of functions externally
> > but declaring them locally. This patch creates a
> > new header (linux/kernel_init.h) and moves all
> > the declarations into it.
> 
> These functions are only referenced in init/main.c, and rightfully so.
> In the end, this doesn't change anything much, other than maintainance
> overhead for the new include/linux/kernel_init.h
>...

I disagree.

Without having looked deeper at the details of this specific patch, it's 
generally a good cleanup to move function declarations to header files.

This avoids the nasty class of runtime errors we sometimes get when 
someone changes the prototype of a function but forgets to update all 
the prototypes floating around in .c files.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed