From: Andrea Arcangeli <andrea@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, mason@suse.com
Subject: Re: [PATCH] fix nr_unused accounting, and avoid recursing in iput with I_WILL_FREE set
Date: Wed, 19 Oct 2005 09:47:57 +0200 [thread overview]
Message-ID: <20051019074757.GA30541@x30.random> (raw)
In-Reply-To: <20051018171335.3b308b3e.akpm@osdl.org>
On Tue, Oct 18, 2005 at 05:13:35PM -0700, Andrew Morton wrote:
> Well according to my assertion (below), the inode in __sync_single_inode()
> cannot have a zero refcount, so the whole if() statement is never executed.
It can, but only if it comes from I_WILL_FREE path
(generic_forget_inode). See the write_inode_now in
generic_forget_inode.
My BUG_ON already makes sure that when i_count is zero, I_WILL_FREE is
set (I_WILL_FREE will prevent the inode to be freed by the vm as well,
so it's ok).
prev parent reply other threads:[~2005-10-19 7:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-18 8:26 [PATCH] fix nr_unused accounting, and avoid recursing in iput with I_WILL_FREE set Andrea Arcangeli
2005-10-19 0:13 ` Andrew Morton
2005-10-19 0:40 ` Chris Mason
2005-10-19 1:15 ` Andrew Morton
2005-10-19 1:58 ` Chris Mason
2005-10-19 2:26 ` Andrew Morton
2005-10-19 2:58 ` Chris Mason
2005-10-25 2:21 ` Chris Mason
2005-10-25 14:14 ` Andrea Arcangeli
2005-10-19 7:47 ` Andrea Arcangeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051019074757.GA30541@x30.random \
--to=andrea@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mason@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.