All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Christoph Hellwig <hch@infradead.org>,
	Lee Revell <rlrevell@joe-job.com>,
	Mark Knecht <markknecht@gmail.com>,
	linux-kernel@vger.kernel.org, rmk@arm.linux.org.uk,
	Linus Torvalds <torvalds@osdl.org>, Andrew Morton <akpm@osdl.org>,
	andmike@us.ibm.com, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] scsi_error thread exits in TASK_INTERRUPTIBLE state.
Date: Wed, 19 Oct 2005 13:56:53 +0200	[thread overview]
Message-ID: <20051019115653.GA2127@elte.hu> (raw)
In-Reply-To: <Pine.LNX.4.58.0510190751070.20634@localhost.localdomain>


* Steven Rostedt <rostedt@goodmis.org> wrote:

> On Wed, 19 Oct 2005, Christoph Hellwig wrote:
> 
> > > +	/*
> > > +	 * There's a good chance that the loop will exit in the
> > > +	 * TASK_INTERRUPTIBLE state.
> > > +	 */
> > > +	__set_current_state(TASK_RUNNING);
> >
> > no need to comment the obvious.
> 
> So, should I resend the patch without the comment?

i guess so. OTOH, if it was so obvious, why did it stay unfixed for so 
long ;-)

	Ingo

  parent reply	other threads:[~2005-10-19 11:56 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-18 21:02 scsi_eh / 1394 bug - -rt7 Mark Knecht
2005-10-19  3:43 ` Lee Revell
2005-10-19  4:19   ` Lee Revell
2005-10-19  7:10     ` Steven Rostedt
2005-10-19  7:54       ` [PATCH] scsi_error thread exits in TASK_INTERRUPTIBLE state Steven Rostedt
2005-10-19 11:31         ` Christoph Hellwig
2005-10-19 11:51           ` Steven Rostedt
2005-10-19 11:54             ` Christoph Hellwig
2005-10-19 12:22               ` Steven Rostedt
2005-10-19 11:56             ` Ingo Molnar [this message]
2005-10-19 11:59               ` Christoph Hellwig
2005-10-19 11:22       ` scsi_eh / 1394 bug - -rt7 Ingo Molnar
2005-10-19 15:23       ` Mark Knecht

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051019115653.GA2127@elte.hu \
    --to=mingo@elte.hu \
    --cc=akpm@osdl.org \
    --cc=andmike@us.ibm.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=markknecht@gmail.com \
    --cc=rlrevell@joe-job.com \
    --cc=rmk@arm.linux.org.uk \
    --cc=rostedt@goodmis.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.