From: "John W. Linville" <linville@tuxdriver.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [patch 2.6.14-rc3 2/3] sundance: probe PHYs from MII address 0
Date: Wed, 19 Oct 2005 08:00:24 -0400 [thread overview]
Message-ID: <20051019120022.GA15438@tuxdriver.com> (raw)
In-Reply-To: <4355B017.4040509@pobox.com>
On Tue, Oct 18, 2005 at 10:31:51PM -0400, Jeff Garzik wrote:
> John W. Linville wrote:
> >--- a/drivers/net/sundance.c
> >+++ b/drivers/net/sundance.c
> >@@ -608,7 +608,7 @@ static int __devinit sundance_probe1 (st
> >
> > np->phys[0] = 1; /* Default setting */
> > np->mii_preamble_required++;
> >- for (phy = 1; phy < 32 && phy_idx < MII_CNT; phy++) {
> >+ for (phy = 0; phy < 32 && phy_idx < MII_CNT; phy++) {
>
> NAK. MII address 0 should be scanned _last_, after all other addresses.
> In some phys, it is a ghost, mirroring another address.
>
> Take a look at some of the original Becker MII scan code from
> ftp://ftp.scyld.com/pub/network/ to see an elegant method for this.
Hmmm...that is clever...patch to follow...
John
--
John W. Linville
linville@tuxdriver.com
next prev parent reply other threads:[~2005-10-19 12:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-19 1:31 [patch 2.6.14-rc3 0/3] misc fixes/cleanups for sundance John W. Linville
2005-10-19 1:31 ` [patch 2.6.14-rc3 1/3] sundance: remove if (1) { ... } block in sundance_probe1 John W. Linville
2005-10-19 1:31 ` [patch 2.6.14-rc3 2/3] sundance: probe PHYs from MII address 0 John W. Linville
2005-10-19 1:31 ` [patch 2.6.14-rc3 3/3] sundance: expand reset mask John W. Linville
2005-10-19 2:29 ` Jeff Garzik
2005-10-19 2:31 ` [patch 2.6.14-rc3 2/3] sundance: probe PHYs from MII address 0 Jeff Garzik
2005-10-19 12:00 ` John W. Linville [this message]
2005-10-19 12:07 ` [patch 2.6.14-rc3] sundance: include MII address 0 in PHY probe John W. Linville
2005-10-20 14:07 ` Jeff Garzik
2005-10-19 2:29 ` [patch 2.6.14-rc3 1/3] sundance: remove if (1) { ... } block in sundance_probe1 Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051019120022.GA15438@tuxdriver.com \
--to=linville@tuxdriver.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.