All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@infradead.org>
To: "Hammer, Jack" <Jack_Hammer@adaptec.com>
Cc: Matthew Wilcox <matthew@wil.cx>,
	akmpm@osdl.org, James.Bottomley@steeleye.com,
	linux-scsi@vger.kernel.org, IpsLinux <ipslinux@adaptec.com>
Subject: Re: ips.c warnings
Date: Thu, 20 Oct 2005 18:29:14 +0100	[thread overview]
Message-ID: <20051020172914.GA32307@infradead.org> (raw)
In-Reply-To: <A121ABA5B472B74EB59076B8E3C8F0190195F824@rtpe2k01.adaptec.com>

On Thu, Oct 20, 2005 at 01:25:28PM -0400, Hammer, Jack wrote:
> 
> I have no problem trying kmap_atomic() as long as there's a sound,
> technical reason for changing code that's worked well for years.
> 
> What are the advantages/reasons of changing to use kmap_atomic() ?   It
> appears very few SCSI drivers use it.

I think the real question is: what are these checks for.  You should never
get an SG list with a NULL struct page or an SGL entry that points to address
0 from the higher level code, and no other drivers checks for that condition.


  reply	other threads:[~2005-10-20 17:29 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-20 17:25 ips.c warnings Hammer, Jack
2005-10-20 17:29 ` Christoph Hellwig [this message]
2005-10-20 17:54   ` James Bottomley
  -- strict thread matches above, loose matches on Subject: below --
2005-10-20 17:59 IpsLinux
2005-10-20 17:38 Salyzyn, Mark
2005-10-20 17:39 ` Christoph Hellwig
2005-10-20 17:33 IpsLinux
2005-10-20 16:59 Jack Hammer
2005-10-20 17:05 ` Matthew Wilcox
2005-10-16 21:08 Andrew Morton
2005-10-16 22:44 ` James Bottomley
2005-10-16 22:57   ` Andrew Morton
2005-10-16 23:11     ` James Bottomley
2005-10-16 23:24       ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051020172914.GA32307@infradead.org \
    --to=hch@infradead.org \
    --cc=Jack_Hammer@adaptec.com \
    --cc=James.Bottomley@steeleye.com \
    --cc=akmpm@osdl.org \
    --cc=ipslinux@adaptec.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=matthew@wil.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.