From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1ET6u5-00010Z-5x for mharc-grub-devel@gnu.org; Fri, 21 Oct 2005 20:06:29 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1ET6u3-00010L-7r for grub-devel@gnu.org; Fri, 21 Oct 2005 20:06:27 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1ET6u1-000109-P6 for grub-devel@gnu.org; Fri, 21 Oct 2005 20:06:27 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1ET6u1-000106-LO for grub-devel@gnu.org; Fri, 21 Oct 2005 20:06:25 -0400 Received: from [212.85.152.101] (helo=kotoba.storever.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1ET6u1-00039S-AF for grub-devel@gnu.org; Fri, 21 Oct 2005 20:06:25 -0400 Received: from ASSP-nospam (localhost [127.0.0.1]) by kotoba.storever.com (Postfix) with ESMTP id 7867A3C7372DF for ; Sat, 22 Oct 2005 04:38:31 +0200 (CEST) Received: from 127.0.0.1 ([127.0.0.1] helo=ip6-localhost) by ASSP-nospam ; 22 Oct 05 02:38:31 -0000 From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Sat, 22 Oct 2005 02:06:22 +0200 User-Agent: KMail/1.7.2 References: <200510211417.41141.T.E.Baldwin99@members.leeds.ac.uk> <200510220024.48173.okuji@enbug.org> <200510220046.33572.T.E.Baldwin99@members.leeds.ac.uk> In-Reply-To: <200510220046.33572.T.E.Baldwin99@members.leeds.ac.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200510220206.22576.okuji@enbug.org> Subject: Re: [patch] 64 bit disk address support (= 8192EiB disks) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 22 Oct 2005 00:06:27 -0000 On Saturday 22 October 2005 01:46 am, Timothy Baldwin wrote: > > I think it is better to define grub_off_t as grub_uint64_t, and use > > grub_off_t. > > Misleading as POSIX uses off_t as a byte offset. Also grub_off_t would be > logical type name for file offsets, which should use a separate type to aid > changing it. I disagree. The development environment of GRUB was created to be intentionally similar to POSIX. For example, look at the usage of grub_size_t. It is rather convenient that one can guess how to program in GRUB based on an experience on POSIX. > Also grub_off_t is used in kern/mm.c to count bytes of memory. What is bad? Okuji