From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Laurent Riffard <laurent.riffard@free.fr>, Greg KH <greg@kroah.com>
Cc: linux-kernel@vger.kernel.org, dmo@osdl.org, mike.miller@hp.com,
iss_storagedev@hp.com, Jeff Garzik <garzik@pobox.com>
Subject: Re: [patch] drivers/block: updates .owner field of struct pci_driver
Date: Sun, 23 Oct 2005 22:13:20 +0100 [thread overview]
Message-ID: <20051023211320.GB19915@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20051023204956.213142000@antares.localdomain>
On Sun, Oct 23, 2005 at 10:49:48PM +0200, Laurent Riffard wrote:
> This patch updates .owner field of struct pci_driver.
>
> This allows SYSFS to create the symlink from the driver to the
> module which provides it.
>
> Signed-off-by: Laurent Riffard <laurent.riffard@free.fr>
Wouldn't it be better to eliminate pci_driver's .owner field and
set the generic device driver's owner field directly? (and fix
the PCI code not to overwrite that if pci_driver's .owner field
is NULL for compatibility.)
I ask for the second time recently on linux-kernel. Is there
*really* any point in duplicating these fields?
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2005-10-23 21:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20051023204947.430464000@antares.localdomain>
2005-10-23 20:49 ` [patch] drivers/block: updates .owner field of struct pci_driver Laurent Riffard
2005-10-23 21:13 ` Russell King [this message]
2005-10-23 21:46 ` Al Viro
2005-10-25 20:17 ` Greg KH
2005-10-23 22:29 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051023211320.GB19915@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=dmo@osdl.org \
--cc=garzik@pobox.com \
--cc=greg@kroah.com \
--cc=iss_storagedev@hp.com \
--cc=laurent.riffard@free.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=mike.miller@hp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.