All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Landley <rob@landley.net>
To: linux-kernel@vger.kernel.org
Subject: [patch] zap broken heuristic in init/main.c
Date: Mon, 24 Oct 2005 02:16:49 -0500	[thread overview]
Message-ID: <200510240216.49358.rob@landley.net> (raw)

From: Rob Landley <rob@landley.net>
Signed-off-by Rob landley <rob@landley.net>

Unknown linux kernel command line arguments are passed through as arguments to
init, unless they have a period in them.
---
I'm trying to run a shell script inside User Mode Linux.  I have an init
wrapper that forks and attaches the child process to /dev/tty0, then waits for
the child to exit.  (I need to do this for ctrl-c to work, pid 1 has kill
blocked and /dev/console has no controlling tty.)  This wrapper uses the
standard execvp(argv[1],argv+1) trick from detach/nohup/setsid and so on.

It worked until I tried to run the production shell script, the name of which
includes the build stage (which has a period in it), and like all the build
shell scripts it ends in .sh.  I get this:

  UML running in SKAS0 mode
  Checking PROT_EXEC mmap in /tmp...OK
  Unknown boot option
    `/home/landley/newbuild/firmware-build/sources/scripts/1.0-tools-umlsetup.sh':
    ignoring
  System halted.

Which sucks.

--- linux-old/init/main.c 2005-09-09 21:42:58.000000000 -0500
+++ linux-new/init/main.c 2005-10-24 02:07:37.683498720 -0500
@@ -242,15 +242,6 @@
  if (obsolete_checksetup(param))
   return 0;
 
- /*
-  * Preemptive maintenance for "why didn't my mispelled command
-  * line work?"
-  */
- if (strchr(param, '.') && (!val || strchr(param, '.') < val)) {
-  printk(KERN_ERR "Unknown boot option `%s': ignoring\n", param);
-  return 0;
- }
-
  if (panic_later)
   return 0;
 

                 reply	other threads:[~2005-10-24  7:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200510240216.49358.rob@landley.net \
    --to=rob@landley.net \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.