All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@nokia.com>
To: bluez-devel@lists.sourceforge.net
Subject: Re: [Bluez-devel] [PATCH] Add CancelInquiry D-BUS method
Date: Mon, 24 Oct 2005 10:56:03 +0300	[thread overview]
Message-ID: <20051024075603.GA9349@localhost.localdomain> (raw)
In-Reply-To: <1130103081.19317.19.camel@blade>

[-- Attachment #1: Type: text/plain, Size: 453 bytes --]

On Sun, Oct 23, 2005, ext Marcel Holtmann wrote:
> > HCI_Inquiry_Cancel command will not cause a inquiry complete HCI event
> > to be generated, so I also changed security.c to send the inquiry
> > complete D-BUS signal when it encounters a command complete event for
> > HCI_Inquiry_Cancel.
> 
> the patch is in the CVS now, thanks.

I forgot one important thing: EVT_CMD_COMPLETE should also be enabled in
the filter. Here's a patch to fix it.

Johan

[-- Attachment #2: cmd-complete.patch --]
[-- Type: text/plain, Size: 622 bytes --]

Index: hcid/security.c
===================================================================
RCS file: /cvsroot/bluez/utils/hcid/security.c,v
retrieving revision 1.42
diff -u -r1.42 security.c
--- hcid/security.c	23 Oct 2005 21:27:41 -0000	1.42
+++ hcid/security.c	24 Oct 2005 07:52:55 -0000
@@ -775,6 +775,7 @@
 	hci_filter_clear(&flt);
 	hci_filter_set_ptype(HCI_EVENT_PKT, &flt);
 	hci_filter_set_event(EVT_CMD_STATUS, &flt);
+	hci_filter_set_event(EVT_CMD_COMPLETE, &flt);
 	hci_filter_set_event(EVT_PIN_CODE_REQ, &flt);
 	hci_filter_set_event(EVT_LINK_KEY_REQ, &flt);
 	hci_filter_set_event(EVT_LINK_KEY_NOTIFY, &flt);

  reply	other threads:[~2005-10-24  7:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-23 21:13 [Bluez-devel] [PATCH] Add CancelInquiry D-BUS method Johan Hedberg
2005-10-23 21:31 ` Marcel Holtmann
2005-10-24  7:56   ` Johan Hedberg [this message]
2005-10-24 11:04     ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051024075603.GA9349@localhost.localdomain \
    --to=johan.hedberg@nokia.com \
    --cc=bluez-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.