All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marcelo Tosatti <marcelo.tosatti@cyclades.com>
To: Andreas Schwab <schwab@suse.de>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: Makefile check for older binutils broken?
Date: Wed, 26 Oct 2005 14:08:59 -0200	[thread overview]
Message-ID: <20051026160859.GA10688@logos.cnet> (raw)
In-Reply-To: <jezmow3v8n.fsf@sykes.suse.de>

On Wed, Oct 26, 2005 at 09:59:20PM +0200, Andreas Schwab wrote:
> Marcelo Tosatti <marcelo.tosatti@cyclades.com> writes:
> 
> > Anyway, surrounding the verification command around an eval expression
> > does the trick correcting the situation. Is it any good? 
> 
> Not at all.  You have effectively disabled the check completely.
> 
> > diff --git a/arch/ppc/Makefile b/arch/ppc/Makefile
> > index 0432a25..cdd9250 100644
> > --- a/arch/ppc/Makefile
> > +++ b/arch/ppc/Makefile
> > @@ -126,7 +126,7 @@ checkbin:
> >  			false; \
> >  		fi ; \
> >  	fi
> > -	@if ! /bin/echo dssall | $(AS) -many -o $(TOUT) >/dev/null 2>&1 ; then \
> > +	@if ! [[ "/bin/echo dssall | $(AS) -many -o $(TOUT) >/dev/null 2>&1" ]] ; then \
> 
> A non-empty string is always true.

Doh - it seemed too easy. I'll go search for some clue (and buy a shell book).

I bet either Make or bash is screwing up.

Thanks

  reply	other threads:[~2005-10-26 21:13 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-26 13:36 Makefile check for older binutils broken? Marcelo Tosatti
2005-10-26 19:59 ` Andreas Schwab
2005-10-26 16:08   ` Marcelo Tosatti [this message]
2005-10-26 22:02 ` Tom Rini
2005-10-28  8:52   ` Marcelo Tosatti
2005-10-28 16:10     ` Tom Rini
2005-10-28 13:14       ` Marcelo Tosatti
2005-11-01 16:33       ` Marcelo Tosatti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051026160859.GA10688@logos.cnet \
    --to=marcelo.tosatti@cyclades.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=schwab@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.