From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mailman by lists.gnu.org with archive (Exim 4.43) id 1EVKV9-0006n6-Kr for mharc-grub-devel@gnu.org; Thu, 27 Oct 2005 23:01:55 -0400 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1EVKV7-0006mw-Vk for grub-devel@gnu.org; Thu, 27 Oct 2005 23:01:54 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1EVKV6-0006mc-FY for grub-devel@gnu.org; Thu, 27 Oct 2005 23:01:53 -0400 Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1EVKV6-0006mZ-Be for grub-devel@gnu.org; Thu, 27 Oct 2005 23:01:52 -0400 Received: from [212.85.152.101] (helo=kotoba.storever.com) by monty-python.gnu.org with esmtp (Exim 4.34) id 1EVKV6-0005iK-1U for grub-devel@gnu.org; Thu, 27 Oct 2005 23:01:52 -0400 Received: from ASSP-nospam (localhost [127.0.0.1]) by kotoba.storever.com (Postfix) with ESMTP id CE3BE3C32E16F for ; Fri, 28 Oct 2005 05:02:48 +0200 (CEST) Received: from 127.0.0.1 ([127.0.0.1] helo=ip6-localhost) by ASSP-nospam ; 28 Oct 05 03:02:48 -0000 From: "Yoshinori K. Okuji" Organization: enbug.org To: The development of GRUB 2 Date: Fri, 28 Oct 2005 05:01:50 +0200 User-Agent: KMail/1.7.2 References: <200510211417.41141.T.E.Baldwin99@members.leeds.ac.uk> <200510220206.22576.okuji@enbug.org> <200510221253.31223.T.E.Baldwin99@members.leeds.ac.uk> In-Reply-To: <200510221253.31223.T.E.Baldwin99@members.leeds.ac.uk> MIME-Version: 1.0 Content-Type: text/plain; charset="iso-2022-jp" Content-Transfer-Encoding: 7bit Content-Disposition: inline Message-Id: <200510280501.50549.okuji@enbug.org> Subject: Re: [patch] 64 bit disk address support (= 8192EiB disks) X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: The development of GRUB 2 List-Id: The development of GRUB 2 List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 28 Oct 2005 03:01:54 -0000 On Saturday 22 October 2005 01:53 pm, Timothy Baldwin wrote: > That is exactly my point. POSIX uses off_t as a byte counts into files, the > type we are discussing the name of is used for sector counts. OK. That makes sense. However, I do not like grub_sector_t. For me, this is still an address or an offset. So it should be called something like grub_disk_addr_t or grub_sector_offset_t. > > > Also grub_off_t is used in kern/mm.c to count bytes of memory. > > > > What is bad? > > It should use grub_size_t for memory, in order follow POSIX. It's true. So we must fix it. Okuji