All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: kernel-janitors@vger.kernel.org
Subject: Re: [KJ] [PATCH] add printk KERN_ constants
Date: Fri, 28 Oct 2005 20:18:35 +0000	[thread overview]
Message-ID: <20051028201835.GE17693@kroah.com> (raw)
In-Reply-To: <fe441c360510281315k6fdf011dx914dae0648e41952@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 971 bytes --]

On Fri, Oct 28, 2005 at 09:15:28PM +0100, Matthew Whitworth wrote:
> Hi,
> 
> I'm just testing the water, here's my first patch. If that's ok,
> there's a lot of things to fix in arch/sh.
> 
> Description:
> printk() calls should include appropriate KERN_* constant.
> 
> Signed-off-by: Matthew Whitworth <mwhitworth@gmail.com>
> 
> diff -uprN linux-2.6.14/arch/sh/mm/fault-nommu.c mod/arch/sh/mm/fault-nommu.c
> --- linux-2.6.14/arch/sh/mm/fault-nommu.c       2005-10-28
> 01:02:08.000000000 +0100

Patch is line-wrapped :(

> +++ mod/arch/sh/mm/fault-nommu.c        2005-10-28 20:09:18.000000000 +0100
> @@ -59,7 +59,7 @@ asmlinkage void do_page_fault(struct pt_
>                printk(KERN_ALERT "Unable to handle kernel paging request");
>        }
> 
> -       printk(" at virtual address %08lx\n", address);
> +       printk(KERN_ALERT " at virtual address %08lx\n", address);

The tabs were all eaten by your email client :(

please try again.

thanks,

greg k-h

[-- Attachment #2: Type: text/plain, Size: 168 bytes --]

_______________________________________________
Kernel-janitors mailing list
Kernel-janitors@lists.osdl.org
https://lists.osdl.org/mailman/listinfo/kernel-janitors

  reply	other threads:[~2005-10-28 20:18 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-28 20:15 [KJ] [PATCH] add printk KERN_ constants Matthew Whitworth
2005-10-28 20:18 ` Greg KH [this message]
2005-10-28 20:30 ` Randy.Dunlap
2005-10-28 20:32 ` Matthew Whitworth
2005-10-28 20:50 ` Alexey Dobriyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051028201835.GE17693@kroah.com \
    --to=greg@kroah.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.