From: Al Viro <viro@ftp.linux.org.uk>
To: Marcel Holtmann <marcel@holtmann.org>
Cc: Linus Torvalds <torvalds@osdl.org>,
linux-kernel@vger.kernel.org, Dmitry Torokhov <dtor@mail.ru>,
Martin Schwidefsky <schwidefsky@de.ibm.com>
Subject: Re: [PATCH] bluetooth hidp is broken on s390
Date: Sat, 29 Oct 2005 19:47:58 +0100 [thread overview]
Message-ID: <20051029184758.GL7992@ftp.linux.org.uk> (raw)
In-Reply-To: <1130583949.6428.1.camel@blade>
On Sat, Oct 29, 2005 at 01:05:49PM +0200, Marcel Holtmann wrote:
> Hi Al,
>
> > Bluetooth HIDP selects INPUT and it really needs it to be
> > there - module depends on input core. And input core is never
> > built on s390... Marked as broken on s390, for now; if somebody
> > has better ideas, feel free to fix it and remove dependency...
> >
> > Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>
>
> basically I think someone should fix the input layer on S390, but I am
> fine with your fix.
There's a problem with that patch, though ;-/ S390 is never defined by
arch/s390/Kconfig; ARCH_S390 is. From the fast grep it looks like there
is one more place with the same problem: drivers/char/Kconfig has
config HW_CONSOLE
bool
depends on VT && !S390 && !UML
default y
and the second term is always true here. Why do we have that dependency,
anyway, when s390 doesn't include drivers/char/Kconfig at all?
next prev parent reply other threads:[~2005-10-29 18:48 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-29 11:02 [PATCH] bluetooth hidp is broken on s390 Al Viro
2005-10-29 11:05 ` Marcel Holtmann
2005-10-29 18:47 ` Al Viro [this message]
2005-10-31 9:01 ` Martin Schwidefsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051029184758.GL7992@ftp.linux.org.uk \
--to=viro@ftp.linux.org.uk \
--cc=dtor@mail.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=schwidefsky@de.ibm.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.