From: Andi Kleen <ak@suse.de>
To: Roland Dreier <rolandd@cisco.com>
Cc: "Martin J. Bligh" <mbligh@mbligh.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
discuss@x86-64.org
Subject: Re: [PATCH] x86_64: Work around Re: 2.6.14-git1 (and -git2) build failure on AMD64
Date: Sun, 30 Oct 2005 17:23:31 +0100 [thread overview]
Message-ID: <200510301723.31561.ak@suse.de> (raw)
In-Reply-To: <52br17nfmk.fsf@cisco.com>
On Sunday 30 October 2005 17:17, Roland Dreier wrote:
> Andi> Linus, can you please apply it?
>
> No, please don't apply this. The correct fix is to mark
> toshiba_ohci1394_dmi_table[] as __devinitdata in that file, as in the
> patch I posted here:
>
> http://lkml.org/lkml/2005/10/29/12
While not correct I don't see how it should guarantee it will
work around that gcc bug on all possible gcc versions (which show
different behaviour) My patch is more conservative and safer.
-Andi
next prev parent reply other threads:[~2005-10-30 16:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-30 14:03 2.6.14-git1 (and -git2) build failure on AMD64 Martin J. Bligh
2005-10-30 14:17 ` Roland Dreier
2005-10-30 15:28 ` Andi Kleen
2005-10-30 15:50 ` Martin J. Bligh
2005-10-30 16:15 ` Roland Dreier
2005-10-30 15:49 ` [PATCH] x86_64: Work around " Andi Kleen
2005-10-30 16:17 ` Roland Dreier
2005-10-30 16:23 ` Andi Kleen [this message]
2005-10-30 16:32 ` Roland Dreier
2005-11-02 5:16 ` Martin J. Bligh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200510301723.31561.ak@suse.de \
--to=ak@suse.de \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@mbligh.org \
--cc=rolandd@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.