From: Pavel Machek <pavel@suse.cz>
To: Alexandre Oliva <aoliva@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: amd64 bitops fix for -Os
Date: Sun, 30 Oct 2005 20:23:24 +0100 [thread overview]
Message-ID: <20051030192323.GF657@openzaurus.ucw.cz> (raw)
In-Reply-To: <orvezggf7x.fsf@livre.oliva.athome.lsd.ic.unicamp.br>
Hi!
> This patches fixes a bug that comes up when compiling the kernel for
> x86_64 optimizing for size. It affects 2.6.14 for sure, but I'm
> pretty sure many earlier kernels are affected as well.
Is the same problem in i386, too?
> --- arch/x86_64/lib/bitops.c~ 2005-10-27 22:02:08.000000000 -0200
> +++ arch/x86_64/lib/bitops.c 2005-10-29 18:24:27.000000000 -0200
> @@ -1,5 +1,11 @@
> #include <linux/bitops.h>
>
> +#define BITOPS_CHECK_UNDERFLOW_RANGE 0
> +
> +#if BITOPS_CHECK_UNDERFLOW_RANGE
> +# include <linux/kernel.h>
> +#endif
Could you drop the ifdefs? Nice for debugging but we don't
want them in mainline.
Plus you want to add signed-off-by: header and send it to ak@suse.de.
Pavel
--
64 bytes from 195.113.31.123: icmp_seq=28 ttl=51 time=448769.1 ms
next prev parent reply other threads:[~2005-10-30 19:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-29 21:56 amd64 bitops fix for -Os Alexandre Oliva
2005-10-29 23:41 ` Randy.Dunlap
2005-10-30 10:56 ` Alexandre Oliva
2005-10-30 19:23 ` Pavel Machek [this message]
2005-10-31 20:09 ` Alexandre Oliva
2005-10-31 21:14 ` Pavel Machek
2005-10-31 17:24 ` Randy Dunlap
2005-10-31 20:29 ` Alexandre Oliva
2005-10-31 20:59 ` Randy.Dunlap
2005-11-03 18:55 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051030192323.GF657@openzaurus.ucw.cz \
--to=pavel@suse.cz \
--cc=aoliva@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.