From: Olaf Hering <olh@suse.de>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: paulus@samba.org, akpm@osdl.org, linuxppc64-dev@ozlabs.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ppc64: add MODALIAS= for vio bus
Date: Mon, 31 Oct 2005 08:38:34 +0100 [thread overview]
Message-ID: <20051031073834.GA4868@suse.de> (raw)
In-Reply-To: <20051031134814.42940751.sfr@canb.auug.org.au>
On Mon, Oct 31, Stephen Rothwell wrote:
> Hi Olaf,
>
> This patch breaks lagacy iSeries i.e. it won't link (iSeries has no get_property()).
> It may be easier to redo this patch against Paulus' merge tree.
Can you fix it up, why is there no get_property for iseries, yet?
iseries_veth should be autoloaded in a similar way.
Maybe it should just go into a CONFIG_PSERIES or whatever.
> A couple of trivial comments:
>
> On Sun, 30 Oct 2005 22:39:00 +0100 Olaf Hering <olh@suse.de> wrote:
> >
> > +static int pseries_vio_hotplug (struct device *dev, char **envp, int num_envp,
> ^
> No space here, please.
>
> > + length = scnprintf (buffer, buffer_size, "MODALIAS=vio:T%sS%s",
> ^
> No space here either, please.
I copied it from macio_asic.c.
--
short story of a lazy sysadmin:
alias appserv=wotan
next prev parent reply other threads:[~2005-10-31 7:38 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-10-30 21:39 [PATCH] ppc64: add MODALIAS= for vio bus Olaf Hering
2005-10-31 2:48 ` Stephen Rothwell
2005-10-31 7:38 ` Olaf Hering [this message]
2005-11-05 12:13 ` Olaf Hering
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051031073834.GA4868@suse.de \
--to=olh@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc64-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.