All of lore.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Jan Engelhardt <jengelh@linux01.gwdg.de>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	netdev@vger.kernel.org
Subject: [2.6 patch] fix the "QoS and/or fair queueing" menu
Date: Mon, 31 Oct 2005 11:26:21 +0100	[thread overview]
Message-ID: <20051031102621.GF8009@stusta.de> (raw)
In-Reply-To: <Pine.LNX.4.61.0510280902470.6910@yvahk01.tjqt.qr>

On Fri, Oct 28, 2005 at 09:04:31AM +0200, Jan Engelhardt wrote:

> Hi,

Hi Jan,

> When CONFIG_NET_CLS is enabled, then "Firewall based classifier", "U32 
> classifier" and some more appear under the "Network options" menu rather 
> than "QoS and/or fair queueing" menu.
> This bug is in the recently released 2.6.14. (And earlier).

thanks for this report, a patch is below.

> Jan Engelhardt

cu
Adrian


<--  snip  -->


This patch adjust some dependencies in net/sched/Kconfig for getting all 
options that belong there under "QoS and/or fair queueing".

There is no actual semantic change in any dependency, the additional 
dependencies are added for helping kconfig to figure out what belongs to 
that menu.


Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 net/sched/Kconfig |   16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

--- linux-2.6.14-rc5-mm1-full/net/sched/Kconfig.old	2005-10-31 11:08:50.000000000 +0100
+++ linux-2.6.14-rc5-mm1-full/net/sched/Kconfig	2005-10-31 11:18:48.000000000 +0100
@@ -343,6 +343,7 @@
 
 config NET_CLS_ROUTE
 	bool
+	depends on NET_CLS
 	default n
 
 config NET_CLS_FW
@@ -375,7 +376,7 @@
 
 config NET_CLS_IND
 	bool "classify input device (slows things u32/fw) "
-	depends on NET_CLS_U32 || NET_CLS_FW
+	depends on NET_CLS && (NET_CLS_U32 || NET_CLS_FW)
 	help
 	  This option will be killed eventually when a 
           metadata action appears because it slows things a little
@@ -552,13 +553,6 @@
         requires new iproute2
         This allows for packets to be generically edited
 
-config NET_CLS_POLICE
-	bool "Traffic policing (needed for in/egress)"
-	depends on NET_CLS && NET_QOS && NET_CLS_ACT!=y
-	help
-	  Say Y to support traffic policing (bandwidth limits).  Needed for
-	  ingress and egress rate limiting.
-
 config NET_ACT_SIMP
         tristate "Simple action"
         depends on NET_CLS_ACT
@@ -569,3 +563,9 @@
 	All this action will do is print on the console the configured
 	policy string followed by _ then packet count.
 
+config NET_CLS_POLICE
+        bool "Traffic policing (needed for in/egress)"
+        depends on NET_CLS && NET_QOS && NET_CLS_ACT!=y
+        help
+          Say Y to support traffic policing (bandwidth limits).  Needed for
+          ingress and egress rate limiting.


  reply	other threads:[~2005-10-31 10:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-10-28  7:04 QoS in menuconfig screwed up Jan Engelhardt
2005-10-31 10:26 ` Adrian Bunk [this message]
2005-10-31 13:27   ` [2.6 patch] fix the "QoS and/or fair queueing" menu Thomas Graf
2005-11-01 14:13     ` [PKT_SCHED]: Rework QoS and/or fair queueing configuration Thomas Graf
2005-11-01 19:54       ` Ian McDonald
2005-11-01 21:47         ` Patrick McHardy
2005-11-03  4:25       ` Arnaldo Carvalho de Melo

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051031102621.GF8009@stusta.de \
    --to=bunk@stusta.de \
    --cc=jengelh@linux01.gwdg.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.