From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: [PATCH] befs: use generic_ro_fops Date: Tue, 1 Nov 2005 00:35:33 +0100 Message-ID: <20051031233533.GA20976@lst.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-fsdevel@vger.kernel.org Return-path: Received: from verein.lst.de ([213.95.11.210]:57254 "EHLO mail.lst.de") by vger.kernel.org with ESMTP id S1751330AbVJaXfq (ORCPT ); Mon, 31 Oct 2005 18:35:46 -0500 To: akpm@osdl.org, rathamahata@php4.ru Content-Disposition: inline Sender: linux-fsdevel-owner@vger.kernel.org List-Id: linux-fsdevel.vger.kernel.org no need to duplicate a generic readonly file ops table in befs. Signed-off-by: Christoph Hellwig Index: linux-2.6/fs/befs/linuxvfs.c =================================================================== --- linux-2.6.orig/fs/befs/linuxvfs.c 2005-10-31 12:23:55.000000000 +0100 +++ linux-2.6/fs/befs/linuxvfs.c 2005-10-31 15:02:12.000000000 +0100 @@ -73,12 +73,6 @@ .lookup = befs_lookup, }; -static struct file_operations befs_file_operations = { - .llseek = default_llseek, - .read = generic_file_read, - .mmap = generic_file_readonly_mmap, -}; - static struct address_space_operations befs_aops = { .readpage = befs_readpage, .sync_page = block_sync_page, @@ -398,7 +392,7 @@ inode->i_mapping->a_ops = &befs_aops; if (S_ISREG(inode->i_mode)) { - inode->i_fop = &befs_file_operations; + inode->i_fop = &generic_ro_fops; } else if (S_ISDIR(inode->i_mode)) { inode->i_op = &befs_dir_inode_operations; inode->i_fop = &befs_dir_operations;