From: Dmitry Torokhov <dtor_core@ameritech.net>
To: Ian Wienand <ianw@gelato.unsw.edu.au>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Convert dmasound_awacs to dynamic input_dev allocation
Date: Tue, 1 Nov 2005 01:14:38 -0500 [thread overview]
Message-ID: <200511010114.38632.dtor_core@ameritech.net> (raw)
In-Reply-To: <20051101060443.GF11202@cse.unsw.EDU.AU>
On Tuesday 01 November 2005 01:04, Ian Wienand wrote:
> On Tue, Nov 01, 2005 at 12:55:31AM -0500, Dmitry Torokhov wrote:
> > Now you are leaking memory if something else fails... FOr example when
> > chip is not present.
>
> Good point. I guess the original comment is because the final
> dmasound_init() can fail but we'll still have all sorts of memory,
> irq's and io that aren't cleaned up. So your previous patch probably
> introduces the least problems.
>
Have you tried it by any chance? I'd feel much better pushing it upstream
knowing that it was tested at least once...
--
Dmitry
next prev parent reply other threads:[~2005-11-01 6:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-01 2:03 [PATCH] Convert dmasound_awacs to dynamic input_dev allocation Ian Wienand
2005-11-01 3:17 ` Dmitry Torokhov
2005-11-01 3:59 ` Ian Wienand
2005-11-01 5:14 ` Dmitry Torokhov
2005-11-01 5:50 ` Ian Wienand
2005-11-01 5:55 ` Dmitry Torokhov
2005-11-01 6:04 ` Ian Wienand
2005-11-01 6:14 ` Dmitry Torokhov [this message]
2005-11-01 10:33 ` Ian Wienand
2005-11-01 13:03 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200511010114.38632.dtor_core@ameritech.net \
--to=dtor_core@ameritech.net \
--cc=ianw@gelato.unsw.edu.au \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.