From: Christoph Hellwig <hch@lst.de>
To: Trond Myklebust <trond.myklebust@fys.uio.no>
Cc: akpm@osdl.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH 2/8] move xattr permission checks into the VFS
Date: Tue, 1 Nov 2005 04:38:15 +0100 [thread overview]
Message-ID: <20051101033815.GA24605@lst.de> (raw)
In-Reply-To: <1130816004.19963.16.camel@lade.trondhjem.org>
On Mon, Oct 31, 2005 at 10:33:23PM -0500, Trond Myklebust wrote:
> ...but then I'm a bit confused w.r.t. your removal of the checks for
> S_ISREG(inode->i_mode) & friends in nfs4proc.c nfs4_setxattr(). You
> motivate the removal by the fact that you've moved those checks into the
> VFS, but AFAICS we will never hit the VFS checks for the case of
> system.nfs4_acl (which is the only case we care about right now).
Hmm, that's was at least half of an oversight. The other filesystems
do exactly this check only for user ACLs. Posix ACLs are supported
on all files but links and in the other filesystems these link checks
are hidden much deeper in the callchanin.
If this check is the right thing for NFSv4 ACLs we should drop the nfs
patch.
prev parent reply other threads:[~2005-11-01 3:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-01 2:30 [PATCH 2/8] move xattr permission checks into the VFS Christoph Hellwig
2005-11-01 3:22 ` Trond Myklebust
2005-11-01 3:24 ` Christoph Hellwig
2005-11-01 3:33 ` Trond Myklebust
2005-11-01 3:38 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051101033815.GA24605@lst.de \
--to=hch@lst.de \
--cc=akpm@osdl.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.