Re: [patch, rfc] LEDs support for collie

[Pavel Machek <pavel@suse.cz>]

Hi!

> > This adds support for controlling LEDs on sharp zaurus sl-5500. It may
> > look a little bit complex, but it probably needs to be complex --
> > blinking is pretty much mandatory when you only have two leds, and we
> > want to support charging led (controlled by kernel).
> 
> Isn't "blinking" a kind of policy, as is brightness (== duty cycle of
> a high speed toggling)?  What if someone wants synchronised toggling?
> 
> I still think anything over a very simple interface being exported to
> userspace is completely overkill and completely bloated.  Hell, I got
> laughed at for creating an abstracted LEDs interface in the first
> place because many thought the current version was far too bloated.

Well, waking userspace for every blink is going to be expensive,
power-wise. Plus we really need the blinking in kernel -- to
communicate charger error to user.

> I _know_ people have issues with the current interface, whinging that
> "it only exports the colour" but that's something which is actually
> very trivially solvable and therefore _not_ a major problem to solve.

Where's the current interface? I'll be happy to plug collie into that
one...
								Pavel
-- 
Thanks, Sharp!