All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@nokia.com>
To: bluez-devel@lists.sourceforge.net
Subject: Re: [Bluez-devel] [PATCH] Better D-BUS path tracking
Date: Wed, 2 Nov 2005 20:40:09 +0200	[thread overview]
Message-ID: <20051102183915.GA13523@localhost.localdomain> (raw)
In-Reply-To: <1130948271.5442.12.camel@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 551 bytes --]

Hi Marcel,

> > This patch introduces a new path_id field to the hci_dbus_data struct as
> > well as renames the id field to dev_id. This allows more accurate path
> > identification in the callback functions. It also removes the need to do
> > hard-to-follow string manipulations to find out the child path component.
> 
> the patch is in the CVS now.

The patch contained by mistake also the authenticate patch I sent earlier.
After applying it the code calls twice dbus_message_new_method_return. Sorry
about that. Here's a patch to fix it.

Johan

[-- Attachment #2: memleak-fix.patch --]
[-- Type: text/plain, Size: 413 bytes --]

Index: dbus.c
===================================================================
RCS file: /cvsroot/bluez/utils/hcid/dbus.c,v
retrieving revision 1.43
diff -u -r1.43 dbus.c
--- dbus.c	2 Nov 2005 15:44:05 -0000	1.43
+++ dbus.c	2 Nov 2005 18:35:32 -0000
@@ -1705,8 +1705,6 @@
 
 	reply = dbus_message_new_method_return(msg);
 
-	reply = dbus_message_new_method_return(msg);
-
 failed:
 	if (dd >= 0)
 		close(dd);

  reply	other threads:[~2005-11-02 18:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-11-02 15:32 [Bluez-devel] [PATCH] Better D-BUS path tracking Johan Hedberg
2005-11-02 16:17 ` Marcel Holtmann
2005-11-02 18:40   ` Johan Hedberg [this message]
2005-11-02 18:47     ` Marcel Holtmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20051102183915.GA13523@localhost.localdomain \
    --to=johan.hedberg@nokia.com \
    --cc=bluez-devel@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.