From: Mitchell Blank Jr <mitch@sfgoth.com>
To: Kris Katterjohn <kjak@users.sourceforge.net>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
jschlst@samba.org, davem@davemloft.net, acme@ghostprotocols.net,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Merge __load_pointer() and load_pointer() in net/core/filter.c; kernel 2.6.14
Date: Wed, 2 Nov 2005 22:58:09 -0800 [thread overview]
Message-ID: <20051103065809.GC27232@gaz.sfgoth.com> (raw)
In-Reply-To: <5b1bc8f2a7f34523b323fc1b58ef4c26.kjak@ispwest.com>
Kris Katterjohn wrote:
> > From: Mitchell Blank Jr
> > > (I trimmed the cc: list a bit; no need for this to be on LKML in my opinion)
I see you just added it back. Oh well.
> > So I guess use my patch and take "inline" off? What do you think?
Well the original author presumably thought that the fast-path of
load_pointer() was critical enough to keep inline (since it can be run many
times per packet) So they made the deliberate choice of separating it
into two functions - one inline, one non-inline.
So my personal feeling is that the code is probably fine as it stands today.
> Maybe "static" should be removed, too? Oh well.
Uh, why? It's clearly a file-local function.
-Mitch
next prev parent reply other threads:[~2005-11-03 6:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-03 6:19 [PATCH] Merge __load_pointer() and load_pointer() in net/core/filter.c; kernel 2.6.14 Kris Katterjohn
2005-11-03 6:58 ` Mitchell Blank Jr [this message]
2005-11-03 16:19 ` Patrick McHardy
-- strict thread matches above, loose matches on Subject: below --
2005-11-03 18:13 [PATCH] Merge __load_pointer() and load_pointer() in net/core/filter.c;kernel 2.6.14 Kris Katterjohn
2005-11-03 5:51 [PATCH] Merge __load_pointer() and load_pointer() in net/core/filter.c; kernel 2.6.14 Kris Katterjohn
2005-11-03 2:48 Kris Katterjohn
2005-11-03 2:13 Kris Katterjohn
2005-11-03 2:30 ` Herbert Xu
2005-11-02 8:41 Kris Katterjohn
2005-11-03 1:50 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051103065809.GC27232@gaz.sfgoth.com \
--to=mitch@sfgoth.com \
--cc=acme@ghostprotocols.net \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=jschlst@samba.org \
--cc=kjak@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.