From: Matthew Wilcox <matthew@wil.cx>
To: Linus Torvalds <torvalds@osdl.org>
Cc: linux-kernel@vger.kernel.org, Matthew Wilcox <matthew@wil.cx>
Subject: First steps towards making NO_IRQ a generic concept
Date: Thu, 3 Nov 2005 07:49:26 -0700 [thread overview]
Message-ID: <20051103144926.GV23749@parisc-linux.org> (raw)
Hi Linus,
This series of four patches are the first step towards making NO_IRQ a
pervasive concept. It's bundled up in a git tree for your convenience
(unless I bodged it up, in which case it's your inconvenience).
git://git.kernel.org/pub/scm/linux/kernel/git/willy/misc-2.6.git no_irq
- Check the irq number is within bounds in the functions which weren't
already checking.
- Introduce PCI_NO_IRQ and pci_valid_irq()
Explicitly initialise pci_dev->irq with PCI_NO_IRQ, allowing us to change
the value of PCI_NO_IRQ when all drivers have been audited.
- Use pci_valid_irq() instead of a custom NO_IRQ definition.
It probably didn't work on half a dozen architectures.
- Move the definition of NO_IRQ from asm directories to <linux/hardirq.h>.
Individual architectures can still override it if they want to, but all
existing definitions were -1.
drivers/pci/probe.c | 7 +++++--
drivers/pcmcia/pd6729.c | 6 +-----
include/asm-arm/irq.h | 8 --------
include/asm-arm26/irq.h | 8 --------
include/asm-frv/irq.h | 3 ---
include/asm-parisc/irq.h | 2 --
include/asm-powerpc/irq.h | 3 ---
include/linux/hardirq.h | 10 ++++++++++
include/linux/pci.h | 9 +++++++++
kernel/irq/manage.c | 15 +++++++++++++++
10 files changed, 40 insertions(+), 31 deletions(-)
I'll follow this mail with the patches for other peoples benefits. They
were previously posted to linux-arch with no responses.
next reply other threads:[~2005-11-03 14:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-03 14:49 Matthew Wilcox [this message]
2005-11-03 14:51 ` First steps towards making NO_IRQ a generic concept Matthew Wilcox
2005-11-03 15:44 ` Ingo Molnar
2005-11-03 16:02 ` Matthew Wilcox
2005-11-03 16:20 ` Ingo Molnar
2005-11-03 17:05 ` Matthew Wilcox
2005-11-03 20:53 ` Ingo Molnar
2005-11-03 14:51 ` Matthew Wilcox
2005-11-03 17:15 ` Arjan van de Ven
2005-11-03 14:52 ` Matthew Wilcox
2005-11-03 14:52 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051103144926.GV23749@parisc-linux.org \
--to=matthew@wil.cx \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.