From: Christoph Hellwig <hch@infradead.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Christoph Hellwig <hch@infradead.org>,
davej@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] export ia64_max_cacheline_size
Date: Fri, 4 Nov 2005 23:52:57 +0000 [thread overview]
Message-ID: <20051104235257.GA21674@infradead.org> (raw)
In-Reply-To: <20051104145534.17e913f2.akpm@osdl.org>
On Fri, Nov 04, 2005 at 02:55:34PM -0800, Andrew Morton wrote:
> > Can we please move dma_get_cache_alignment() out of line instead?
>
> It's a single statement! It wants to be inlined.
>
> > Always export sane APIs instead of random internals.
>
> The exported API is dma_get_cache_alignment(). For internal implementation
> reasons we need to export an ia64 symbol to modules to support it. That
> kinda sucks, but I don't think that we need to compromise kernel size and
> performance because of it.
It's an API used only in slow pathes. It's much better to enforce modularity
in that case.
next prev parent reply other threads:[~2005-11-04 23:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-11-04 22:07 [PATCH] export ia64_max_cacheline_size Dave Jones
2005-11-04 22:34 ` Christoph Hellwig
2005-11-04 22:55 ` Andrew Morton
2005-11-04 23:52 ` Christoph Hellwig [this message]
2005-11-05 0:05 ` Andrew Morton
2005-11-05 4:35 ` John W. Linville
2005-11-05 4:37 ` [patch 2.6.14] ia64: re-implement dma_get_cache_alignment to avoid EXPORT_SYMBOL John W. Linville
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20051104235257.GA21674@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.